Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosts documentation for the cargo packages. #68

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Hosts documentation for the cargo packages. #68

merged 6 commits into from
Apr 29, 2024

Conversation

francocipollone
Copy link
Contributor

🎉 New feature

Related to #57

Summary

Host documentation on github.io

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Hosts documentation for the cargo packages.
942eb03 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Adds permissions.
fd14c8f 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Copy link
Contributor Author

francocipollone commented Apr 23, 2024 •
edited
Loading

Reminder to myself

  • Once it is done testing remove francocipollone/gh-pages branch from github-pages environment

@francocipollone
Fix
1deccdc 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Use enable-index-page
fb7e980 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Some more fixes.
fffbff1 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone mentioned this pull request Apr 23, 2024
Closed
@francocipollone
Narrow down to main branch
50f3f4b 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone marked this pull request as ready for review April 23, 2024 20:26
@francocipollone
Copy link
Contributor Author

This is the deployed github pages: https://maliput.github.io/maliput-rs/

@francocipollone
Copy link
Contributor Author

Note this commment: #57 (comment)
on why this online doc is still necessary and the easiest step to get online docs

agalbachicar
agalbachicar approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 8e58b5a into main Apr 29, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/gh_pages branch April 29, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar