-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read bazel lib version using bazel CLI instead of hardcoding it. #76
Read bazel lib version using bazel CLI instead of hardcoding it. #76
Conversation
Signed-off-by: Agustin Alba Chicar <ag.albachicar@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Check clippy. CI is also failing weirdly.
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
One interesting thing happened: CC @agalbachicar You were using
You see in the 4th line that the cargo:CXXBRIDGE_DIR0 command isn't parsed correctly and then the cxx configuration go bananas. The bottom line is: Avodining regular prints in build.rs files might be the best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Extra comment: @agalbachicar |
Thanks @francocipollone ! |
🎉 New feature
Closes #74
Summary
Executes
bazel mod explain
to obtainmaliput
andmaliput_malidrive
library versions inmaliput-sdk/build.rs
.Test it
By executing cargo check / build.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.