This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
Remove gflags dependency #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `time colcon build --packages-select maliput_drake` on this branch yields: ```sh time colcon build --packages-select maliput_drake ... Summary: 1 package finished [3min 3s] 1 package had stderr output: maliput_drake real 3m3.806s user 18m27.039s sys 0m36.838s ``` whereas in main branch: ```sh time colcon build --packages-select maliput_drake ... Summary: 1 package finished [4min 0s] 1 package had stderr output: maliput_drake real 4m0.630s user 21m50.783s sys 0m43.339s ```
This was referenced Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes on top of #9
Removes the only file depending on gflags and the dependency with it.
Part of #6
Should review only ff1f824