Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bazel version information to presubmit.yml file. #275

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Feb 20, 2024

🦟 Bug fix

Related to maliput/maliput-rs#10 (comment)
Related to bazelbuild/bazel-central-registry#1423

Summary

Adds bazel version to presubmit.yml file. This is required by the bazel registry CI

image
https://buildkite.com/bazel/bcr-presubmit/builds/3456#018d6ba5-7ba7-46ea-a71e-b8e89d46e6ff

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone changed the title uAdds bazel version information to presubmit.yml file. Adds bazel version information to presubmit.yml file. Feb 21, 2024
@francocipollone
Copy link
Collaborator Author

image

Failing CI at lane_test due to a timeout

agalbachicar
agalbachicar previously approved these changes Feb 26, 2024
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone merged commit 5499d9f into main Feb 26, 2024
4 checks passed
@francocipollone francocipollone deleted the francocipollone/bazel_version_presubmit branch February 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants