Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run from Enviroments that do not directly have Pycall #493

Merged
merged 10 commits into from
Jan 30, 2019

Conversation

oxinabox
Copy link
Collaborator

This adds a Project.toml
so that we can run the workers in the TensorFlow enviroment,
which will have PyCall for sure.

When making the Project.toml i did not both to transcribe the Compat rules,
since they are basically not julia 0.7 compat anyway.

@oxinabox oxinabox requested a review from malmaud as a code owner January 29, 2019 11:30
@malmaud
Copy link
Owner

malmaud commented Jan 29, 2019

Cool cool. Is there a guide somewhere on how Project.toml and the whole environment-based package system works?

@oxinabox
Copy link
Collaborator Author

Pkg.jl docs.

It could be better, but I have tried and I can't make it better yet.

@malmaud
Copy link
Owner

malmaud commented Jan 29, 2019

OK, I get what this PR does now. Looks good, merge when you're ready.

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #493 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   49.04%   49.32%   +0.28%     
==========================================
  Files          79       79              
  Lines        2659     2668       +9     
==========================================
+ Hits         1304     1316      +12     
+ Misses       1355     1352       -3
Impacted Files Coverage Δ
src/TensorFlow.jl 57.89% <100%> (ø) ⬆️
src/version.jl 73.33% <0%> (+10.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8ff66...434a778. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #493 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   49.04%   49.32%   +0.28%     
==========================================
  Files          79       79              
  Lines        2659     2668       +9     
==========================================
+ Hits         1304     1316      +12     
+ Misses       1355     1352       -3
Impacted Files Coverage Δ
src/TensorFlow.jl 57.89% <100%> (ø) ⬆️
src/version.jl 73.33% <0%> (+10.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8ff66...434a778. Read the comment docs.

@oxinabox oxinabox merged commit bffc711 into master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants