User info when SAML respons lacks SNIN or person name

malmostad · Jun 11, 2018 · b5ca71b · b5ca71b
1 parent df49559
commit b5ca71b
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/app/controllers/seller_auth_controller.rb b/app/controllers/seller_auth_controller.rb
@@ -22,7 +22,15 @@ def consume
       redirect_to(root_path, alert: 'Inloggning misslyckades') && return
     end
 
-    seller = update_seller(response.attributes['Subject_SerialNumber'], response.attributes['Subject_CommonName'])
+    serial_number      = response.attributes['Subject_SerialNumber']
+    subject_commonname = response.attributes['Subject_CommonName']
+
+    unless serial_number && subject_commonname
+      logger.error '[SAML_AUTH] Response has no Subject_SerialNumber (SNIN) or Subject_CommonName'
+      redirect_to(root_path, alert: 'Inloggningen misslyckades. Personnummer och/eller personnamn saknas i responsen från inloggningstjänsten.') && return
+    end
+
+    seller = update_seller(serial_number, subject_commonname)
 
     unless seller
       logger.warn '[SAML_AUTH] User not registered in the system.'