#4 Configure deployment automation

[malparty]

#4 Configure deployment automation

What happened

GitHub Action Deploy Heroku is now working for staging env and deploys the app here

Insight

• Update deploy_heroku.yml to map with the right registry token and Heroku App name (underscores not accepted by heroku)
• Create default route so that the test can be fully done

Proof Of Work

Staging App available here

[malparty]

(Unit tests are passing, I just did not bring the changes from previous PR into this branch)

[github-actions]

	3 Errors
🚫	Brakeman static analysis detected issues in the code. If this is a false positive, mark it as such.
🚫	Code coverage data not found
🚫	Undercover: coverage report cannot be found.

BRAKEMAN REPORT

Application path	Rails version	Brakeman version	Started at	Duration
/home/runner/work/google-search-ruby/google-search-ruby	6.1.3.1	5.0.1	2021-06-10 08:25:18 +0000	1.859606934 seconds

Checks performed

BasicAuth, BasicAuthTimingAttack, CSRFTokenForgeryCVE, ContentTag, CookieSerialization, CreateWith, CrossSiteScripting, DefaultRoutes, Deserialize, DetailedExceptions, DigestDoS, DynamicFinders, EscapeFunction, Evaluation, Execute, FileAccess, FileDisclosure, FilterSkipping, ForgerySetting, HeaderDoS, I18nXSS, JRubyXML, JSONEncoding, JSONEntityEscape, JSONParsing, LinkTo, LinkToHref, MailTo, MassAssignment, MimeTypeDoS, ModelAttrAccessible, ModelAttributes, ModelSerialize, NestedAttributes, NestedAttributesBypass, NumberToCurrency, PageCachingCVE, PermitAttributes, QuoteTableName, Redirect, RegexDoS, Render, RenderDoS, RenderInline, ResponseSplitting, RouteDoS, SQL, SQLCVEs, SSLVerify, SafeBufferManipulation, SanitizeMethods, SelectTag, SelectVulnerability, Send, SendFile, SessionManipulation, SessionSettings, SimpleFormat, SingleQuotes, SkipBeforeFilter, SprocketsPathTraversal, StripTags, SymbolDoSCVE, TemplateInjection, TranslateBug, UnsafeReflection, UnsafeReflectionMethods, ValidationRegex, VerbConfusion, WithoutProtection, XMLDoS, YAMLParsing

SUMMARY

Scanned/Reported	Total
Controllers	2
Models	1
Templates	3
Errors	0
Security Warnings	1 (0)

Warning Type	Total
Cross-Site Scripting	1

SECURITY WARNINGS

Confidence	Class	Method	Warning Type	Message
Medium			Cross-Site Scripting	loofah gem 2.10.0 is vulnerable (CVE-2018-8048). Upgrade to 2.2.1 near line 212

Generated by 🚫 Danger

[ankitkalia1195]

@malparty Can you check why the Build Docker image (push) is failing, also the unit and system tests can be run again.

[malparty]

@malparty Can you check why the Build Docker image (push) is failing, also the unit and system tests can be run again.

This was because I did not merge from develop before. It's now done, tests are passing ✅ ;-)

[junan]

@malparty How about adding the Heroku url in readme? Just like this. It will be easier for other developers to find out the server url without checking from the PR description.

Merge branch 'develop' into chore/setup-deployment

And regarding updating the local branch from the base branch, we use Git's rebase instead of merge as rebase provides cleaner commit history. You can use rebase in your nest PRs when you need to get update from the base branch 👍