Release - 0.2.0 #42
Merged
Release - 0.2.0 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase from setup deployment workflows
…rty/google-search-ruby into feature/user-login-backend Pull from GitHub
[#5][Backend] As a User, I can sign up and sign in/out with a username and password
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| protected | ||
|
|
||
| def update_allowed_parameters | ||
| devise_parameter_sanitizer.permit(:sign_up) do |u| |
There was a problem hiding this comment.
| Has the variable name 'u' |
| devise_parameter_sanitizer.permit(:sign_up) do |u| | ||
| u.permit(:first_name, :last_name, :email, :password, :password_confirmation) | ||
| end | ||
| devise_parameter_sanitizer.permit(:account_update) do |u| |
There was a problem hiding this comment.
| Has the variable name 'u' |
| # the authenticate method from devise documentation | ||
| def self.authenticate(email, password) | ||
| user = User.find_for_authentication(email: email) | ||
| user&.valid_password?(password) ? user : nil |
There was a problem hiding this comment.
| Is controlled by argument 'password' |
| login_as user, scope: :user | ||
| end | ||
|
|
||
| def sign_up_ui(email, password, password_confirm = nil) |
BRAKEMAN REPORT
SUMMARY
SECURITY WARNINGS
Generated by 🚫 Danger |
| fill_in 'user_last_name', with: user.last_name | ||
| fill_in 'user_email', with: email | ||
| fill_in 'user_password', with: password | ||
| fill_in 'user_password_confirmation', with: password_confirm || password |
There was a problem hiding this comment.
| Is controlled by argument 'password_confirm' |
junan
approved these changes
Jun 21, 2021
|
@malparty I think we don't need In compass release we add |
ankitkalia1195
approved these changes
Jun 21, 2021
Thanks! Time saver for future releases!! :) :) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
User web authentication with Devise.
Preview available in Staging
Features
Chores
N/ABugs
N/A