Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable button when upload is complete #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dejakob
Copy link

@dejakob dejakob commented Jan 16, 2019

At the current state, the upload button gets disabled when choosing an image, but gets enabled again before uploading.

IMO, we should only enable it again

  • After the upload was successful
  • Or the upload was dismissed
  • Or there was some kind of error
  • Or a custom button was pressed

At the current state, the upload button gets disabled when choosing an image, but gets enabled again before uploading.
IMO, we should only enable it again
* After the upload was successful
* Or the upload was dismissed
* Or there was some kind of error
* Or a custom button was pressed
Copy link

@AdamGold AdamGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, what you did here is a re-use of the same code in every scenario. Can't see how that changes behavior. Anything I'm missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants