Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc update. Props are height and width. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor doc update. Props are height and width. #73

wants to merge 1 commit into from

Conversation

patrice4github
Copy link

Minor doc update. From the code we can read that it's height and width, not maxHeight and maxWidth:


state = {
    maxHeight: this.props.height || 600,
    maxWidth: this.props.width || 600,

Using height instead maxHeight worked correctly on my app. Setting
maxHeight had no effect.

…d width, not maxHeight and maxWidth:

state = {
    maxHeight: this.props.height || 600,
    maxWidth: this.props.width || 600,


Using height instead maxHeight worked correctly on my app. Setting 
maxHeight had no effect.
@patrice4github patrice4github changed the title Minor doc update. From the code, we can read that props are height an… Minor doc update. Props are height and width. Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants