Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

React 17 #78

wants to merge 2 commits into from

Conversation

scottcanoni
Copy link

I am using this library in a project and to resolve the warnings I am receiving, the peerDeps need to be bumped to allow React 17. I have tested this in 17.0.2 without issue. Should be completely safe to merge.

Also linted innerSize.js as it was throwing lint errors using the built-in .eslintrc rules

@scottcanoni scottcanoni marked this pull request as ready for review April 4, 2021 15:39
Copy link
Author

@scottcanoni scottcanoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if I did anything wrong or could do anything better, thank you kindly. I welcome feedback.

@samueljim
Copy link

bump

@ivosh
Copy link

ivosh commented Dec 10, 2021

Works also for me with React 17.0.2.

@kashuab-cs
Copy link

Bump @malte-wessel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants