Merge pull request #29 from mamantoha/proxy-client-write-timeout

proxy client write timeout

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+* Add `HTTP::Proxy::Client#write_timeout` ([#29](https://github.com/mamantoha/http_proxy/pull/29))
+* Add specs for proxy client with auth ([#28](https://github.com/mamantoha/http_proxy/pull/28))
+
 ## 0.10.0
 
 * Refactor `HTTP::Proxy::Client`

src/ext/http/client.cr

@@ -14,7 +14,8 @@ module HTTP
           tls: @tls,
           dns_timeout: @dns_timeout,
           connect_timeout: @connect_timeout,
-          read_timeout: @read_timeout
+          read_timeout: @read_timeout,
+          write_timeout: @write_timeout
         )
       rescue ex : IO::Error
         raise IO::Error.new("Failed to open TCP connection to #{@host}:#{@port} (#{ex.message})")

src/http/proxy/client.cr

@@ -24,6 +24,7 @@ module HTTP
       @dns_timeout : Float64?
       @connect_timeout : Float64?
       @read_timeout : Float64?
+      @write_timeout : Float64?
 
       # Creates a new socket factory that tunnels via the given host and port.
       # The following optional arguments are supported:
@@ -42,10 +43,11 @@ module HTTP
 
       # Returns a new socket connected to the given host and port via the
       # proxy that was requested when the socket factory was instantiated.
-      def open(host, port, tls = nil, *, @dns_timeout, @connect_timeout, @read_timeout) : IO
+      def open(host, port, tls = nil, *, @dns_timeout, @connect_timeout, @read_timeout, @write_timeout) : IO
         socket = TCPSocket.new(@host, @port, @dns_timeout, @connect_timeout)
         socket.read_timeout = @read_timeout if @read_timeout
-        socket.sync = true
+        socket.write_timeout = @write_timeout if @write_timeout
+        socket.sync = false
 
         if tls
           socket << "CONNECT #{host}:#{port} HTTP/1.1\r\n"
@@ -65,6 +67,7 @@ module HTTP
           end
 
           socket << "\r\n"
+          socket.flush
 
           resp = HTTP::Client::Response.from_io(socket, ignore_body: true)