Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public api for lab extension #37

Merged
merged 2 commits into from
May 19, 2020
Merged

Fix public api for lab extension #37

merged 2 commits into from
May 19, 2020

Conversation

fcollonval
Copy link
Member

The update environment was not part of the public interface. And so it was not accessible to third-party extension using the conda manager token.

In addition the token and the extension public interfaces have been moved to a tokens.ts file to respect JLab convention and minimize bundle size when jupyterlab_conda is an optional dependencies (i.e. it needs to be set as classical node dependency but webpack will only keep tokens.ts file in the bundle).

@fcollonval fcollonval merged commit 40d0774 into master May 19, 2020
@fcollonval fcollonval deleted the fix-public-API branch May 19, 2020 10:46
fcollonval added a commit that referenced this pull request May 20, 2020
* fileName is optional for import and update env

* Move public API and token to token.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant