Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Clarify env subcommand documentation in help menu #3502

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Oct 3, 2024

Fix #3500.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Oct 3, 2024
@jjerphan jjerphan marked this pull request as ready for review October 3, 2024 12:23
Co-authored-by: Hind-M <70631848+Hind-M@users.noreply.github.com>
@jjerphan jjerphan merged commit 5e30f9f into mamba-org:main Oct 15, 2024
27 of 32 checks passed
@jjerphan jjerphan deleted the maint/clarify-env-subcommand branch October 15, 2024 15:07
@@ -143,7 +143,7 @@ __fish_mamba_complete_subcmds '__fish_mamba_has_command' '
config Configuration of micromamba
info Information about micromamba
constructor Commands to support using micromamba in constructor
env List environments
env Access information about environments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help message should be consistent (the same) everywhere:

Suggested change
env Access information about environments
env See `mamba/micromamba env --help`.

@@ -87,7 +87,7 @@ set_umamba_command(CLI::App* com, mamba::Configuration& config)
);
set_constructor_command(constructor_subcom, config);

CLI::App* env_subcom = com->add_subcommand("env", "List environments");
CLI::App* env_subcom = com->add_subcommand("env", "Access information about environments");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CLI::App* env_subcom = com->add_subcommand("env", "Access information about environments");
CLI::App* env_subcom = com->add_subcommand("env", "See `mamba/micromamba env --help`.");

@jjerphan
Copy link
Member Author

My bad #3539 fixes the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

micromamba env does not show any environments in v2.0.2, despite having lots of environments
3 participants