-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: Clarify env
subcommand documentation in help menu
#3502
Merged
jjerphan
merged 2 commits into
mamba-org:main
from
jjerphan:maint/clarify-env-subcommand
Oct 15, 2024
Merged
maint: Clarify env
subcommand documentation in help menu
#3502
jjerphan
merged 2 commits into
mamba-org:main
from
jjerphan:maint/clarify-env-subcommand
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Closed
3 tasks
Hind-M
reviewed
Oct 3, 2024
Co-authored-by: Hind-M <70631848+Hind-M@users.noreply.github.com>
JohanMabille
approved these changes
Oct 15, 2024
Hind-M
reviewed
Oct 15, 2024
@@ -143,7 +143,7 @@ __fish_mamba_complete_subcmds '__fish_mamba_has_command' ' | |||
config Configuration of micromamba | |||
info Information about micromamba | |||
constructor Commands to support using micromamba in constructor | |||
env List environments | |||
env Access information about environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The help
message should be consistent (the same) everywhere:
Suggested change
env Access information about environments | |
env See `mamba/micromamba env --help`. |
@@ -87,7 +87,7 @@ set_umamba_command(CLI::App* com, mamba::Configuration& config) | |||
); | |||
set_constructor_command(constructor_subcom, config); | |||
|
|||
CLI::App* env_subcom = com->add_subcommand("env", "List environments"); | |||
CLI::App* env_subcom = com->add_subcommand("env", "Access information about environments"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
CLI::App* env_subcom = com->add_subcommand("env", "Access information about environments"); | |
CLI::App* env_subcom = com->add_subcommand("env", "See `mamba/micromamba env --help`."); |
My bad #3539 fixes the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3500.