Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to set an extra spec #26

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Conversation

adriendelsalle
Copy link
Member

Description

A way to add extra specs and pinning depending on variables (python matrix build, etc.) would be to pass extra specs to micromamba command: micromamba create -n <env-name> -f <spec-file> <extra-specs>

@wolfv
Copy link
Member

wolfv commented Oct 19, 2021

did you compile the program using npm run build?

@wolfv
Copy link
Member

wolfv commented Oct 19, 2021

@wolfv
Copy link
Member

wolfv commented Oct 19, 2021

btw you probably need to rebase now as I merged some stuff.

@beckermr
Copy link
Collaborator

Why do we need this PR? You can simply install the extra spec yourself using micromamba in the activated env, right?

@adriendelsalle
Copy link
Member Author

adriendelsalle commented Oct 19, 2021

@beckermr the use case is

  • having a environment.yml file with python or pybind11, without pinning Python version
  • you want a matrix build for several Python versions

Then you don't want to install everything then solve again (+download, extract, link..) to downgrade all packages right?
You see better approaches?

@beckermr
Copy link
Collaborator

I see what you mean for the double solves. I guess I am ok with that but this does seem like a nice hook for optimization. Thanks for the PR!

@wolfv
Copy link
Member

wolfv commented Oct 20, 2021

I wonder if we should add quoting or if we should accept a list of specs here and then quote each on individually

@wolfv
Copy link
Member

wolfv commented Oct 20, 2021

Because there is the issue with 'python>=3.8' being a bash redirection

@adriendelsalle
Copy link
Member Author

good question, I was also wondering how to do it

support multiline extra specs
double quote each extra spec to avoid shell errors (redirection > in
bash, etc.)
add tests
add new input in README, add example
@adriendelsalle adriendelsalle marked this pull request as ready for review October 20, 2021 09:02
@adriendelsalle
Copy link
Member Author

@wolfv @beckermr I think this one is ready for reviews

@adriendelsalle
Copy link
Member Author

I'll include a matrix test also to be sure it works as expected

@wolfv
Copy link
Member

wolfv commented Oct 20, 2021

cool! looks good to me!

@wolfv wolfv merged commit 413150b into mamba-org:main Oct 20, 2021
@AntoinePrv
Copy link
Member

That's great! Thanks @adriendelsalle.

Would it make sens to make a release for this, or is there one planned soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants