add support for bearer token and loading token from filesystem #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @wolfv. I'll review this by EOW. |
janjagusch
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Thanks for the PR, @wolfv. When was the support for Bearer tokens implemented into Quetz? I haven't seen any recent PR about that. Or is that something we get for free from FastAPI?
src/quetz_client/cli.py
Outdated
Comment on lines
32
to
35
| if token: | ||
| return ApiKey(token) | ||
| elif bearer_token is not None: | ||
| return BearerToken(bearer_token) |
There was a problem hiding this comment.
Why does token default to an empty string but bearer_token defaults to None? Why don't both default to None?
|
Hey @janjagusch actually, it's not really implemented in quetz but useful in conjunction with a Google IAM Proxy. The IAM proxy takes a classic "bearer" token and then allows you to upload to quetz (when quetz is configured with the google IAP plugin that's in an open PR right now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.