Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination in package list #125

Merged
merged 8 commits into from
Jul 27, 2022
Merged

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jul 26, 2022

This PR fix some issues of pagination in packages list view :

  • vertical alignment
    before :
    image
    After :
    image

  • always show the widget to select the number of packages to show (even if there is currently only one page)
    image

Not fixed : the options of the select widget do not show properly

Copy link
Contributor

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brichet! Looks good. I left a minor comment

.eslintrc.js Outdated Show resolved Hide resolved
@hbcarlos
Copy link
Contributor

Thanks, @brichet!

@hbcarlos hbcarlos merged commit fac8033 into mamba-org:main Jul 27, 2022
@brichet brichet deleted the fix/pagination branch August 5, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants