Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support theming #98

Merged
merged 22 commits into from
Feb 23, 2022
Merged

Support theming #98

merged 22 commits into from
Feb 23, 2022

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Feb 9, 2022

Use @jupyter-notebook/react-components (breadcrumb, avatar, search box, button, tooltip and tabs panel)
Drop react-tooltip (tooltip comes from the new dependency)
Add theme picker menu if there is more than one theme available
Change styles for supporting theming
Use JupyterLab Router every where
Support PUT request on settings and GET single settings plugin (required to support theme)

For now the settings are not persisted (changed in memory)

@fcollonval fcollonval marked this pull request as ready for review February 22, 2022 15:51
@fcollonval fcollonval merged commit a4421c0 into mamba-org:main Feb 23, 2022
@fcollonval fcollonval deleted the ft/theming branch February 23, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant