Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more channel_actions #230

Merged
merged 2 commits into from
Dec 11, 2020
Merged

add more channel_actions #230

merged 2 commits into from
Dec 11, 2020

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Dec 10, 2020

No description provided.

quetz/tasks/common.py Outdated Show resolved Hide resolved
quetz/tasks/mirror.py Outdated Show resolved Hide resolved
@wolfv wolfv force-pushed the merge_actions branch 2 times, most recently from 7514b01 to 6407275 Compare December 10, 2020 17:58
quetz/main.py Outdated Show resolved Hide resolved
logger.debug(f"adding file '{file.filename}' to channel '{channel_name}'")
file.file._file.seek(0, os.SEEK_END)
size = file.file._file.tell()
total_size += size
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the channel size limit: do we want to check whether all the files can be uploaded or we do that one by one and fail after N files have been already uploaded

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to fail early instead of halfway through.

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #230 (9a15570) into master (e552b8a) will increase coverage by 0.21%.
The diff coverage is 83.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   83.50%   83.71%   +0.21%     
==========================================
  Files          31       31              
  Lines        2346     2414      +68     
==========================================
+ Hits         1959     2021      +62     
- Misses        387      393       +6     
Impacted Files Coverage Δ
quetz/dao.py 90.78% <ø> (ø)
quetz/tasks/mirror.py 91.58% <ø> (ø)
quetz/tasks/common.py 80.48% <45.45%> (-13.07%) ⬇️
quetz/authorization.py 95.16% <50.00%> (-0.75%) ⬇️
quetz/tasks/assertions.py 75.00% <50.00%> (-25.00%) ⬇️
quetz/pkgstores.py 56.06% <71.42%> (+3.09%) ⬆️
quetz/tasks/indexing.py 98.13% <97.87%> (-0.26%) ⬇️
quetz/repo_data.py 93.33% <100.00%> (+6.66%) ⬆️
quetz/rest_models.py 99.20% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e552b8a...9a15570. Read the comment docs.

@wolfv wolfv merged commit 76d64bd into mamba-org:master Dec 11, 2020
@wolfv wolfv deleted the merge_actions branch December 11, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants