-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more channel_actions #230
Conversation
7514b01
to
6407275
Compare
logger.debug(f"adding file '{file.filename}' to channel '{channel_name}'") | ||
file.file._file.seek(0, os.SEEK_END) | ||
size = file.file._file.tell() | ||
total_size += size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the channel size limit: do we want to check whether all the files can be uploaded or we do that one by one and fail after N files have been already uploaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to fail early instead of halfway through.
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 83.50% 83.71% +0.21%
==========================================
Files 31 31
Lines 2346 2414 +68
==========================================
+ Hits 1959 2021 +62
- Misses 387 393 +6
Continue to review full report at Codecov.
|
No description provided.