Make cache timeout for GCS configurable #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great to me. Thanks so much! |
|
Looks like we have some problems with the mamba api -- completely unrelated to this PR. Will get to fix that soon! |
|
@wolfv, would it be possible to release a new version, after this PR has been merged? we'd love to use this feature as soon as possible. 🙂 |
|
Hey, I just fixed the mamba tests (#496) If they are green, I'll merge & re-run tests here. Then we can release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #488.
I also bumped the requirement for gcsfs, since an issue with disabled caching was fixed in version
2022.02.0.