Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GCS bucket location configurable #512

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

janjagusch
Copy link
Collaborator

Closes #511

@janjagusch
Copy link
Collaborator Author

Linting error will disappear after #513 is merged.

@janjagusch
Copy link
Collaborator Author

janjagusch commented Apr 5, 2022

I'm not entirely sure what to do about the failing unit tests:

authlib.integrations.base_client.errors.MismatchingStateError: mismatching_state: CSRF Warning! State not equal in request and response.
2022-04-05T16:45:36.8956085Z quetz/tests/authentification/test_oauth.py::test_config_create_user_with_role_in_different_provider[jupyter_response-user_roles0-None] FAILED [ 94%]

But this seems to affect multiple PRs and is probably not related to my changes.

Seems to be related to authlib: lepture/authlib#376

@janjagusch
Copy link
Collaborator Author

I'm not entirely sure what to do about the failing unit tests:

authlib.integrations.base_client.errors.MismatchingStateError: mismatching_state: CSRF Warning! State not equal in request and response.
2022-04-05T16:45:36.8956085Z quetz/tests/authentification/test_oauth.py::test_config_create_user_with_role_in_different_provider[jupyter_response-user_roles0-None] FAILED [ 94%]

But this seems to affect multiple PRs and is probably not related to my changes.

Seems to be related to authlib: lepture/authlib#376

Also fixed in #513

@wolfv wolfv added the enhancement New feature or request label Apr 6, 2022
@wolfv
Copy link
Member

wolfv commented Apr 6, 2022

Thanks, this looks good to me!

@wolfv
Copy link
Member

wolfv commented Apr 6, 2022

I just rebased to see if tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #512 (16d8507) into main (1ea9475) will decrease coverage by 0.91%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   83.21%   82.29%   -0.92%     
==========================================
  Files          78       78              
  Lines        5891     5892       +1     
==========================================
- Hits         4902     4849      -53     
- Misses        989     1043      +54     
Impacted Files Coverage Δ
quetz/config.py 89.63% <ø> (ø)
quetz/pkgstores.py 42.45% <0.00%> (-11.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea9475...16d8507. Read the comment docs.

@wolfv wolfv merged commit bd2d1fc into mamba-org:main Apr 6, 2022
@janjagusch
Copy link
Collaborator Author

Thanks for merging this so quickly, @wolfv! Would it be too much to ask for a new Quetz release, so we try out this feature? 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring bucket location with GCS backend
3 participants