Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proxy channels noarch and gzip repodata #529

Merged
merged 1 commit into from
May 11, 2022

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented May 11, 2022

@janjagusch this fixes the noarch issue for proxy channels and also adds the same gzip mechanism we use with regualr channels which should speed up repodata retrieval substantially (if you're not encoding the stream elsewhere anyways).

Let me know what you think.

@wolfv
Copy link
Member Author

wolfv commented May 11, 2022

aaand there are a couple unrelated changes ... one sec :)

@janjagusch
Copy link
Collaborator

aaand there are a couple unrelated changes ... one sec :)

should i wait for CI to go ✅ before reviewing this?

@wolfv
Copy link
Member Author

wolfv commented May 11, 2022

@janjagusch looks like the CI issue is unrelated. Looking into that now.

@wolfv wolfv added the bug Something isn't working label May 11, 2022
@wolfv
Copy link
Member Author

wolfv commented May 11, 2022

This should be green now.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #529 (f094ab2) into main (f094ab2) will not change coverage.
The diff coverage is n/a.

❗ Current head f094ab2 differs from pull request most recent head 8d5187d. Consider uploading reports for the commit 8d5187d to get more accurate results

@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          78       78           
  Lines        5919     5919           
=======================================
  Hits         4922     4922           
  Misses        997      997           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f094ab2...8d5187d. Read the comment docs.

Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@wolfv wolfv merged commit 42f9b9d into mamba-org:main May 11, 2022
@wolfv wolfv deleted the fix_proxy_channels branch May 11, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants