Log post_index_creation exceptions #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
May 12, 2022
| ) | ||
| logger.debug("Finished post_index_creation for {sdir} of {channel_name}") | ||
| except Exception: | ||
| logger.exception("Exception post_index_creation:") |
There was a problem hiding this comment.
Is there something missing? exception isn't part of the logger? or is there some magic when usign logger.exception?
There was a problem hiding this comment.
Ah, OK, I looked it up, and there is some magic with logger.exception that I wasn't aware of :)
There was a problem hiding this comment.
Yes logging.exception provides some syntactic sugar to make exception logging a bit easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quetz allows to add plugins to modify the repodata info before they are written to disk or bucket.
This PR adds proper exceptions handling to log plugin exceptions and prevent cases where a plugin error causes no repodata be written to disk at all.