-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix / consistent usage of f-strings #538
Fix / consistent usage of f-strings #538
Conversation
* Fix missing `f` for massage strings with placeholders otherwise unresolved. * Favor f-strings over `.format()` when sensible to do so. * Follow-up from mamba-org#526.
* Follow-up from mamba-org#526
You could also consider running: https://github.com/asottile/pyupgrade But that won't catch the many errors you fixed as well! :) |
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
I have actually found and used a flake8 plugin https://pypi.org/project/flake8-use-fstring/ to easily spot |
* Also unpack argument name and value to make the code more idiomatic.
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 83.11% 82.01% -1.11%
==========================================
Files 78 78
Lines 5936 5977 +41
==========================================
- Hits 4934 4902 -32
- Misses 1002 1075 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@wolfv, @baszalmstra, I am coming back to this: I have included the |
Follow-up from #526
f
for massage strings with placeholders otherwise unresolved..format()
when sensible to do so.