Remove package from repodata.json #551
Conversation
|
nice, thanks for this PR! I think we should add tests to make sure the two issues are properly fixed. |
|
Sure. |
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
- Coverage 82.79% 81.97% -0.82%
==========================================
Files 78 78
Lines 5964 5971 +7
==========================================
- Hits 4938 4895 -43
- Misses 1026 1076 +50
Continue to review full report at Codecov.
|
|
@brichet it's easiest if you install |
Thanks |
|
As there are no test on |
|
We can, but I would like to put it very high on the priority list. |
| @@ -85,9 +95,12 @@ def test_delete_package_versions_with_package( | |||
|
|
|||
| assert len(versions) == 0 | |||
|
|
|||
| files = pkgstore.list_files(public_channel.name) | |||
| for filename in package_filenames: | |||
| init_files.remove(filename) | |||
There was a problem hiding this comment.
this should not happen when the subdir is noarch because otherwise the client thinks that the channel does not exist.
There was a problem hiding this comment.
I'm not sure to understand.
This code removes the package filenames from the list of channel files (repodata.json, index.html...), to compare the files list before an after removing a package (only the package archive should have been removed).
There was a problem hiding this comment.
Sorry, I thought that you were deleting empty repodata.json files. I should've looked more carefully.
There was a problem hiding this comment.
Clean repodata.json from empty platform when deleting a package
That was the commit message that confused me :)
There was a problem hiding this comment.
No problem, thanks for review
OK, I'm starting updating the tests anyway, it can be on that PR. |
This PR cleans the
repodata.jsonfiles in all platforms which was containing the removed package.Fix #475