-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no file or directory mandatory #558
no file or directory mandatory #558
Conversation
ad6c7e6 allows to create a local storage without configuration file. WARNING : If the database is sqlite, the database url includes the local path to the database file. This database URL can be set from the configuration file or the environmental variable, and currently we don't know where it comes from. This means that if the database url is set in environmental variable and is relative to CWD and a configuration file exists in an other directory => it will fail to start. |
ad6c7e6
to
79c676a
Compare
Codecov ReportBase: 82.92% // Head: 82.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 82.92% 82.92%
=======================================
Files 78 78
Lines 5987 5987
=======================================
Hits 4965 4965
Misses 1022 1022 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @brichet! I left two minor comments.
Everything else looks good to me.
This PR should fix #459
The config file is now not mandatory, but the server will not start if one of the variables
$QUETZ_SQLALCHEMY_DATABASE_URL
and$QUETZ_SESSION_SECRET
is missing.The deployment directory is not mandatory either if the store is not a
LocalStore
. In fact if any other available store has a variable defined.This also adds some basic tests to ensure server does not start without minimal settings.
MISSING TESTS : make sure the server starts correctly without settings file but with environment variables. Haven't found a way to kill it cleanly, so all following tests will fail with
Address already in use
.