Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove httpx pin, fix tests, & test plugins individually #574

Merged
merged 28 commits into from
Dec 14, 2022

Conversation

simonbohnen
Copy link
Collaborator

@simonbohnen simonbohnen commented Nov 16, 2022

This PR removes the pin on httpx, which was causing issues with newer versions of starlette which require httpx>=0.22.0.
See conda-forge/quetz-feedstock#24.

  • Fixed the tests which required changes to work with httpx>=0.22.0
  • Changed plugin testing to not abort when tests have failed for one plugin

@simonbohnen simonbohnen added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Base: 82.57% // Head: 81.69% // Decreases project coverage by -0.87% ⚠️

Coverage data is based on head (64b7659) compared to base (ae38be7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   82.57%   81.69%   -0.88%     
==========================================
  Files          78       78              
  Lines        6059     6059              
==========================================
- Hits         5003     4950      -53     
- Misses       1056     1109      +53     
Impacted Files Coverage Δ
quetz/pkgstores.py 42.45% <0.00%> (-11.60%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonbohnen simonbohnen changed the title Remove httpx pin Remove httpx pin, fix tests, & test plugins individually Nov 17, 2022
@simonbohnen simonbohnen marked this pull request as ready for review November 17, 2022 15:35
Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@janjagusch janjagusch merged commit 7f77638 into mamba-org:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants