Consider packages.conda for index update and channel mirroring #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 83.26% 83.33% +0.06%
==========================================
Files 78 78
Lines 6186 6205 +19
==========================================
+ Hits 5151 5171 +20
+ Misses 1035 1034 -1
☔ View full report in Codecov by Sentry. |
janjagusch
changed the title
janjagusch
reviewed
Jun 2, 2023
|
@YYYasin19, can you please rebase with the latest commit on main? |
I'll look into how the current tests are working and implement some additional ones for .conda packages. |
YYYasin19
force-pushed
the
fix-mirror-conda-packages
branch
from
ee743cb
to
67c4042
Compare
YYYasin19
force-pushed
the
fix-mirror-conda-packages
branch
from
b89e8db
to
ec4f67b
Compare
AndreasAlbertQC
approved these changes
Aug 18, 2023
|
Thank you @YYYasin19! |
janjagusch
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #599: The current implementation neglects packages that are under
packages.condain therepodata.jsonfiles.This PR should close #599; I hope I haven't missed any other places.
There's one reference to
utils/repodata_compare.pybut that file seems to be unused right now.