-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating pre-commit and adding pyproject.toml #34
Conversation
- repo: "https://github.com/pre-commit/pygrep-hooks" | ||
rev: v1.9.0 | ||
hooks: | ||
- id: python-check-blanket-noqa | ||
- id: python-check-blanket-type-ignore | ||
- id: python-use-type-annotations | ||
- repo: "https://github.com/pycqa/isort" | ||
rev: 5.10.1 | ||
hooks: | ||
- id: isort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these checks already included in ruff?
- repo: "https://github.com/fsfe/reuse-tool" | ||
rev: v0.14.0 | ||
hooks: | ||
- id: reuse | ||
additional_dependencies: | ||
- python-debian==0.1.40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the license checking?
Approving to get the repo as you like for the class. I may have to check and revert some changes in the precommit later |
Sorry I didn't have a chance to answer the message. Today as we expected was very hectic. I simply deleted some pre-commits and checked what worked. I remember reading a problem in the logs with isort. So I removed that because it is in ruff. It could just as well be reimplemented. |
No description provided.