updating pre-commit and adding pyproject.toml #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mambelli
requested changes
May 29, 2024
Comment on lines
-23
to
-32
| - repo: "https://github.com/pre-commit/pygrep-hooks" | ||
| rev: v1.9.0 | ||
| hooks: | ||
| - id: python-check-blanket-noqa | ||
| - id: python-check-blanket-type-ignore | ||
| - id: python-use-type-annotations | ||
| - repo: "https://github.com/pycqa/isort" | ||
| rev: 5.10.1 | ||
| hooks: | ||
| - id: isort |
There was a problem hiding this comment.
Are these checks already included in ruff?
Comment on lines
-57
to
-62
| - repo: "https://github.com/fsfe/reuse-tool" | ||
| rev: v0.14.0 | ||
| hooks: | ||
| - id: reuse | ||
| additional_dependencies: | ||
| - python-debian==0.1.40 |
There was a problem hiding this comment.
Why did you remove the license checking?
mambelli
approved these changes
May 29, 2024
|
Approving to get the repo as you like for the class. I may have to check and revert some changes in the precommit later |
|
Sorry I didn't have a chance to answer the message. Today as we expected was very hectic. I simply deleted some pre-commits and checked what worked. I remember reading a problem in the logs with isort. So I removed that because it is in ruff. It could just as well be reimplemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.