Dumped 11 systems (two working). (#13235)

* machine/generalplus_gpl16250soc_video.cpp: Treat DMA destination 0 sprite RAM to work around issue in jak_spmm. * cpu/m6502: Use conventional call stack for SuperXaviX. * super_tv_pc_cart.xml: Verified dump of Double Mouse Party. * machine/spg_renderer.cpp: Fixed lower bit depth modes (added games use 6 bits per pixel modes). New working systems --------------------- Bandai Let's! TV Play Nou to Karada o Kitaeru Taikan Zunou Family Mattore (Japan) [David Haywood, Team Europe] Takara / SSD Company LTD Webdiver DX W-05 Gladion (Japan) [David Haywood, TeamEurope] New systems marked not working -------------------------------- Bandai Let's! TV Play Digital Monster Battle Junction (Japan) [David Haywood, Team Europe] Bandai / SSD Company LTD Let's! TV Play Narikiri Taikan Boukenger Hashire! Ute! Mission Start!! (Japan) [David Haywood, TeamEurope] Bandai / SSD Company LTD Let's! TV Play Taikan Cast Off - Kamen Rider Kabuto Clock Up & Rider Kick!! (Japan) [David Haywood, TeamEurope] Enter Tech Leadsinger II (LS-K2) [David Haywood, Sean Riddle] Epoch / SSD Company LTD Doraemon Taikan Take-copter! Sora Tobu Daibouken (Japan) [David Haywood, TeamEurope] Epoch / SSD Company LTD Ishikawa Ryou Excite Golf (Japan) [David Haywood, TeamEurope] JAKKS Pacific Inc / Santa Cruz Games The Amazing Spider-Man and The Masked Menace (JAKKS Pacific TV Game) [David Haywood, TeamEurope] Radica / FarSight Studios Connectv Real Swing Golf (set 2) [David Haywood, Sean Riddle] WinFun TV Art Design Center [David Haywood, TeamEurope]
mamedev · Jan 17, 2025 · d4ed4c4 · d4ed4c4
1 parent 4832f65
commit d4ed4c4
Show file tree

Hide file tree

Showing 17 changed files with 533 additions and 256 deletions.
diff --git a/hash/super_tv_pc_cart.xml b/hash/super_tv_pc_cart.xml
@@ -40,8 +40,7 @@ license:CC0-1.0
 		<info name="alt_title" value="ダブルマウスパーティー" />
 		<part name="cart" interface="super_tv_pc_cart">
 			<dataarea name="prg" size="0x200000">
-				<!-- baddump because code seems to be corrupt in places -->
-				<rom name="c-03.u1" size="0x200000" crc="94634a7b" sha1="d69ec0a8c6061e749206927ee68dbcf852fcc03e" status="baddump" />
+				<rom name="c-03.u1" size="0x200000" crc="94634a7b" sha1="d69ec0a8c6061e749206927ee68dbcf852fcc03e" />
 			</dataarea>
 		</part>
 	</software>

diff --git a/src/devices/cpu/m6502/oxavix.lst b/src/devices/cpu/m6502/oxavix.lst
@@ -4,7 +4,7 @@
 
 callf_xa3
 	read_stack(SP);
-	write_special_stack(get_codebank());
+	write_special_stack(SP, get_codebank());
 	dec_special_stack();
 	TMP2 = read_pc();
 	PC++;
@@ -40,7 +40,7 @@ retf_imp
 	inc_SP();
 	PC = set_h(PC, read_stack(SP));
 	inc_special_stack();
-	TMP2 = read_special_stack();
+	TMP2 = read_special_stack(SP);
 	set_codebank(TMP2);
 	read_pc();
 	PC++;
@@ -55,7 +55,7 @@ brk_xav_imp
 		read_pc();
 	PC++;
 	}
-	write_special_stack(get_codebank());
+	write_special_stack(SP, get_codebank());
 	set_codebank(0x00); // epo_efdx, rad_ping and rad_mtrk strongly suggest that interrupts must force bank 0 as code jumps to a ROM pointer stored earlier / a fixed pointer to a rom address in bank 0
 	dec_special_stack();
 	write_stack(SP, PC >> 8);
@@ -123,7 +123,7 @@ rti_xav_imp
 	inc_SP();
 	PC = set_h(PC, read_stack(SP));
 	inc_special_stack();
-	TMP2 = read_special_stack();
+	TMP2 = read_special_stack(SP);
 	set_codebank(TMP2);
 	prefetch();
 

diff --git a/src/devices/cpu/m6502/xavix.cpp b/src/devices/cpu/m6502/xavix.cpp
@@ -106,24 +106,52 @@ xavix_device::mi_xavix::mi_xavix(xavix_device *_base)
 	base = _base;
 }
 
-void xavix_device::write_special_stack(uint8_t data)
+void xavix_device::write_special_stack(uint32_t addr, uint8_t data)
 {
-	m_special_stack[m_special_stackpos&0xff] = data;
+	if (m_use_private_stack_for_extra_callf_byte)
+	{
+		m_special_stack[m_special_stackpos & 0xff] = data;
+	}
+	else
+	{
+		write_stack(addr, data);
+	}
 }
 
 void xavix_device::dec_special_stack()
 {
-	m_special_stackpos--;
+	if (m_use_private_stack_for_extra_callf_byte)
+	{
+		m_special_stackpos--;
+	}
+	else
+	{
+		dec_SP();
+	}
 }
 
 void xavix_device::inc_special_stack()
 {
-	m_special_stackpos++;
+	if (m_use_private_stack_for_extra_callf_byte)
+	{
+		m_special_stackpos++;
+	}
+	else
+	{
+		inc_SP();
+	}
 }
 
-uint8_t xavix_device::read_special_stack()
+uint8_t xavix_device::read_special_stack(uint32_t addr)
 {
-	return m_special_stack[m_special_stackpos&0xff];
+	if (m_use_private_stack_for_extra_callf_byte)
+	{
+		return m_special_stack[m_special_stackpos & 0xff];
+	}
+	else
+	{
+		return read_stack(addr);
+	}
 }
 
 

diff --git a/src/devices/cpu/m6502/xavix.h b/src/devices/cpu/m6502/xavix.h
@@ -192,10 +192,10 @@ class xavix_device : public m6502_device {
 	void set_databank(uint8_t bank);
 	uint8_t get_databank();
 
-	void write_special_stack(uint8_t data);
+	void write_special_stack(uint32_t addr, uint8_t data);
 	void dec_special_stack();
 	void inc_special_stack();
-	uint8_t read_special_stack();
+	uint8_t read_special_stack(uint32_t addr);
 
 	/* we store the additional 'codebank' used for far calls in a different, private stack
 	   this seems to be neccessary for 'rad_hnt2' not to crash when bringing up the calibration / score table screens
@@ -211,6 +211,16 @@ class xavix_device : public m6502_device {
 	uint8_t read_zeropage(uint32_t addr);
 	void write_zeropage(uint32_t addr, uint8_t val);
 
+	// Some original XaviX games seemed to suggest that the extra byte of the far calls went to a different
+	// stack, but dblmouse on suprtvpc does direct stack manipulation which challenges this assumption.
+	// It could be a SuperXaviX vs XaviX differences however, so currently leaving this as a toggle for testing.
+	//
+	// pausing in rad_hnt2 (press shift when on the map) is broken without this logic as the stack becomes too
+	// big with the extra bytes
+	//
+	// we currently use the private stack for regular XaviX but not for the later CPUs, however the root cause
+	// of needing it for regular XaviX could be somewhere else
+	bool m_use_private_stack_for_extra_callf_byte = true;
 };
 
 enum {

diff --git a/src/devices/cpu/m6502/xavix2000.cpp b/src/devices/cpu/m6502/xavix2000.cpp
@@ -38,6 +38,7 @@ DEFINE_DEVICE_TYPE(XAVIX2002, xavix2002_device, "xavix2002", "XaviX (SSD 2002) (
 xavix2000_device::xavix2000_device(const machine_config &mconfig, device_type type, const char *tag, device_t *owner, uint32_t clock) :
 	xavix_device(mconfig, type, tag, owner, clock)
 {
+	m_use_private_stack_for_extra_callf_byte = false;
 }
 
 xavix2000_device::xavix2000_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :

diff --git a/src/devices/machine/generalplus_gpl16250soc_video.cpp b/src/devices/machine/generalplus_gpl16250soc_video.cpp
@@ -779,6 +779,11 @@ void gcm394_base_video_device::video_dma_size_trigger_w(address_space &space, ui
 
 	LOGMASKED(LOG_GCM394_VIDEO_DMA, "%s: doing sprite / video DMA source %04x dest %04x size %04x value of 707e (bank) %04x value of 707f %04x\n", machine().describe_context(), m_videodma_source, m_videodma_dest, m_videodma_size, m_707e_spritebank, m_707f );
 
+	// jak_spmm sets dest to 0 when it wants to write to spriteram, looks intentional?
+	// does something else force writes to go to spriteram or does 0 always just mean there?
+	if (m_videodma_dest == 0)
+		m_videodma_dest = 0x7400;
+
 	for (int i = 0; i <= m_videodma_size; i++)
 	{
 		uint16_t dat = space.read_word(m_videodma_source+i);

diff --git a/src/devices/machine/spg_renderer.cpp b/src/devices/machine/spg_renderer.cpp
@@ -255,7 +255,8 @@ void spg_renderer_device::draw_linemap(bool has_extended_tilemaps, const rectang
 		uint32_t tilemap = tilemapregs[2];
 		uint32_t palette_map = tilemapregs[3];
 
-		//popmessage("draw draw_linemap bases %04x %04x\n", tilemap, palette_map);
+		//if (scanline == 128)
+		//	popmessage("draw draw_linemap reg0 %04x reg1 %04x bases %04x %04x\n", tilemapregs[0], tilemapregs[1], tilemap, palette_map);
 
 		//uint32_t xscroll = scrollregs[0];
 		uint32_t yscroll = scrollregs[1];
@@ -294,26 +295,36 @@ void spg_renderer_device::draw_linemap(bool has_extended_tilemaps, const rectang
 		}
 		else
 		{
-			for (int i = 0; i < 320 / 2; i++)
-			{
-				uint8_t palette_entry;
-				uint16_t color;
-				const uint16_t data = spc.read_word(sourcebase + i);
+			const uint32_t attr = tilemapregs[0];
+			const uint8_t bpp = attr & 0x0003;
+			const uint32_t nc_bpp = ((bpp)+1) << 1;
+			uint32_t palette_offset = (attr & 0x0f00) >> 4;
+			palette_offset >>= nc_bpp;
+			palette_offset <<= nc_bpp;
 
-				palette_entry = (data & 0x00ff);
-				color = paletteram[palette_entry];
+			uint32_t bits = 0;
+			uint32_t nbits = 0;
 
-				if (!(color & 0x8000))
-				{
-					m_linebuf[(i * 2) + 0] = color & 0x7fff;
+			for (int i = 0; i < 320; i++)
+			{
+				bits <<= nc_bpp;
+				if (nbits < nc_bpp)
+				{				
+					uint16_t b = spc.read_word(sourcebase++ & 0x3fffff);
+					b = (b << 8) | (b >> 8);
+					bits |= b << (nc_bpp - nbits);
+					nbits += 16;	
 				}
+				nbits -= nc_bpp;
+
+				uint32_t pal = palette_offset + (bits >> 16);
+				bits &= 0xffff;
 
-				palette_entry = (data & 0xff00) >> 8;
-				color = paletteram[palette_entry];
+				uint16_t rgb = paletteram[pal];
 
-				if (!(color & 0x8000))
+				if (!(rgb & 0x8000))
 				{
-					m_linebuf[(i * 2) + 1] = color & 0x7fff;
+					m_linebuf[i] = rgb;
 				}
 			}
 		}

diff --git a/src/mame/mame.lst b/src/mame/mame.lst
@@ -42710,6 +42710,9 @@ dbzscout
 @source:skeleton/kron.cpp
 kron180                         // 1995 Kron Ltd, Ukraine
 
+@source:skeleton/leadsinger2.cpp
+leadsng2
+
 @source:skeleton/lee1214.cpp
 lee1214d                        //
 
@@ -45874,6 +45877,7 @@ batvgc
 rad_gtg
 rad_rsg
 rad_rsgp
+rad_rsgpa
 rad_foot
 rad_bb3
 rad_bb3p
@@ -45917,6 +45921,7 @@ gameu50
 gameu108
 gormiti
 imgame
+jak_spmm
 myac220
 smartfp                         // Smart Fit Park
 smartfpf
@@ -46021,10 +46026,12 @@ zone3d
 ablkickb
 abltenni                        //
 anpantv
+ban_krkk
 comil                           //
 ddr33v
 decathln
 decathlna
+dmbtjunc
 doraglob                        // (c) 2007 VTech
 doraglobf
 doraglobg
@@ -46067,6 +46074,7 @@ virtbb
 virtten
 vtechtvsgr                      // (c) 2006 VTech
 vtechtvssp                      // (c) 2006 VTech
+wfart
 wfcentro
 
 @source:tvgames/spg2xx_digimake.cpp
@@ -46347,6 +46355,7 @@ tak_gin                         //
 tak_geig                        //
 tak_hamr                        //
 tak_town                        //
+tak_wdg                         //
 tak_zuba                        //
 tcarnavi                        //
 tom_tvho                        //
@@ -46364,6 +46373,7 @@ ltv_naru                        //
 domfitad                        //
 dombikec                        //
 epo_dabj
+epo_dtcj
 
 @source:tvgames/xavix_2000.cpp
 ban_omt                         //
@@ -46388,9 +46398,12 @@ ttv_swj                         //
 @source:tvgames/xavix_2002.cpp
 anpanmdx
 apmj2009
+ban_bkgj
 ban_dn1j
 ban_kksj
+ban_utmj
 epo_ntpj
+epo_rgfj
 ban_ordj
 domdance                        //
 domfitch                        //