Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BGFX, BX and BIMG #10789

Merged
merged 7 commits into from
Jan 5, 2023
Merged

Update BGFX, BX and BIMG #10789

merged 7 commits into from
Jan 5, 2023

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Jan 5, 2023

Update libraries (as of 26th of December 2022):

@mmicko mmicko mentioned this pull request Jan 5, 2023
@rb6502 rb6502 merged commit 812e609 into master Jan 5, 2023
@rb6502 rb6502 deleted the update_bgfx branch January 5, 2023 14:42
@happppp
Copy link
Member

happppp commented Jan 5, 2023

Mingw64/GCC with latest updates from pacman fails:
(...) mingw64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/tmmintrin.h:136:1: error: inlining failed in call to 'always_inline' '__m128i _mm_shuffle_epi8(__m128i, __m128i)': target specific option mismatch 136 | _mm_shuffle_epi8 (__m128i __X, __m128i __Y) | ^~~~~~~~~~~~~~~~ ../../../../../3rdparty/bimg/3rdparty/astc-encoder/source/astcenc_vecmathlib_sse_4.h:1109:42: note: called from here 1109 | __m128i result = _mm_shuffle_epi8(t0.m, idxx); | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~

@mmicko
Copy link
Member Author

mmicko commented Jan 5, 2023

@happppp please try #10791 or just mingw_fix branch, to see if this is working on your setup. Fix landed 3 days ago there in repo for same reason.

@happppp
Copy link
Member

happppp commented Jan 5, 2023

It gives the same error.

@mmicko
Copy link
Member Author

mmicko commented Jan 5, 2023

@happppp looks like msse4.2 is needed, but need to upgrade my env in order to try

@happppp
Copy link
Member

happppp commented Jan 5, 2023

I cherry picked the change to 3rdparty.lua, that fixes the compile issue here.

@DopefishJustin
Copy link
Member

I still get build errors unless I make this change:

diff --git a/scripts/src/3rdparty.lua b/scripts/src/3rdparty.lua
index 491450f60a3..a2194107813 100644
--- a/scripts/src/3rdparty.lua
+++ b/scripts/src/3rdparty.lua
@@ -1251,7 +1251,7 @@ project "bimg"
        configuration { "mingw*" }
                defines {
                        "ASTCENC_AVX=0",
-                       "ASTCENC_SSE=2",
+                       "ASTCENC_SSE=20",
                }
        configuration { }

From the code it looks to me like "2" is not a valid value for ASTCENC_SSE.

@happppp
Copy link
Member

happppp commented Jan 10, 2023

I think you're right.
If you want, you could make a PR.

@smf-
Copy link
Member

smf- commented Jan 10, 2023

I cherry picked the change to 3rdparty.lua, that fixes the compile issue here.

Weirdly it worked fine before you did that, now it's broken.

@happppp
Copy link
Member

happppp commented Jan 10, 2023

In my case it was probably the ASTCENC_AVX=0 that fixed the compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants