Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at.cpp: Added NEW MACHINES Ericsson/Nokia WS286 #3162

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

JoakimLarsson
Copy link
Contributor

No description provided.

ROM_REGION(0x20000,"bios", 0)
ROM_LOAD16_BYTE( "RYS_103_1002_R8A_3C00_IC-POS_71.BIN", 0x18000, 0x4000, NO_DUMP)
ROM_LOAD16_BYTE( "RYS_103_1003_R8A_8600_IC-POS_69.BIN", 0x18001, 0x4000, NO_DUMP)
ROM_END
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no dumps at all for this machine then it should not be added as a driver. Add the information in comments instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I am looking for a newer rom, but I can't tell when it pops up, I would think the ews286 works but I want to get it from an actual Nokia branded machine to be authentic, I'll comment it out for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I tried to use ews286 as parent but that didn't validate

@rb6502
Copy link
Contributor

rb6502 commented Feb 1, 2018

In what way is the ROM not authentic?

@ghost
Copy link

ghost commented Feb 1, 2018

well since it is listed as NO_DUMP for all roms, I guess it isn't authentic because it doesn't exist?

@JoakimLarsson
Copy link
Contributor Author

Well, the machine it is dumped from has Ericsson logos but a Nokia keyboard and the roms has Nokia copyright. The roms are authentic but I am not sure for which machine, it could be that someone upgraded the roms from a Nokia machine or the whole motherboard in which case it is a Nokia rom. Or it could be a Ericsson branded delivery after Nokia Data acquired Ericsson Information Systems in which case it is an Ericsson rom with just the copyright patched.

@rb6502 rb6502 merged commit bb1b695 into mamedev:master Feb 2, 2018
belegdol added a commit to belegdol/mame that referenced this pull request Aug 22, 2023
belegdol added a commit to belegdol/mame that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants