Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow file objects as the corpus of load_dictionary #167

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: allow file objects as the corpus of load_dictionary #167

merged 2 commits into from
Oct 18, 2024

Conversation

nrnrk
Copy link

@nrnrk nrnrk commented Oct 18, 2024

Overview

  • Support file objects to load a dictionary
    • Currently, we need to create a file to load a dictionary even if we have data in memory. This change allows us to use the data in memory when loading a dictionary

Testing

  • I've added unit tests to verify the changes

@mammothb mammothb changed the base branch from master to dev October 18, 2024 10:40
@mammothb mammothb merged commit 14d2860 into mammothb:dev Oct 18, 2024
5 checks passed
@mammothb
Copy link
Owner

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrnrk @mammothb