-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RequestEventData
for saving request events
#1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karlatemp
force-pushed
the
karlatemp/serialize-reqest-events
branch
from
June 7, 2021 05:31
4ee7bc3
to
de9d8aa
Compare
Him188
requested changes
Jun 7, 2021
Karlatemp
force-pushed
the
karlatemp/serialize-reqest-events
branch
from
June 21, 2021 03:46
afba0ad
to
bca7fcf
Compare
This comment has been minimized.
This comment has been minimized.
Him188
reviewed
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果设计为每个事件一种 Ticket (或是更好的名称) 是否更好? 名称更精简
public sealed interface EventTicket {
public val botId: Long
}
@Serializable
public class MemberInvitationTicket(
public override val botId: Long,
public val groupId: Long,
public val eventId: Long,
public val invitorId: Long,
public val groupName: String,
public val invitorNick: String,
) : EventTicket
public data class BotInvitedJoinGroupRequestEvent {
public fun createTicket(): MemberInvitationTicket = TODO()
}
用户如果以 MemberInvitationTicket
类型序列化, 则会直接使用 MemberInvitationTicket
的 serializer. 而如果使用 EventTicket
, 用户可以选择使用 contextual serializer 或 polymorphic serializer
Karlatemp
force-pushed
the
karlatemp/serialize-reqest-events
branch
from
August 11, 2021 14:55
bca7fcf
to
56e43c3
Compare
Him188
reviewed
Aug 11, 2021
Him188
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1145