Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add height, width, size and imageType attribute to Image class #1548

Merged
merged 27 commits into from
Sep 15, 2021
Merged

Add height, width, size and imageType attribute to Image class #1548

merged 27 commits into from
Sep 15, 2021

Conversation

sandtechnology
Copy link
Collaborator

@sandtechnology sandtechnology commented Sep 11, 2021 •
edited
Loading

Close #1543 #1204 #1032

可能存在的问题：
1.JVM自带库的图片支持格式受限，可能导致之前可以上传的图片在此更改后无法上传
2.Android方面目前未测试，可能存在问题
编辑：上述问题已通过手搓跨平台代码解决

@Him188 Him188 linked an issue Sep 11, 2021 that may be closed by this pull request
添加image对象图片大小和长宽属性 #1032
Closed
@Him188 Him188 added t:feature 类型: 新特性 N 优先级: 一般 x:protocol 属性: 协议相关 labels Sep 11, 2021
@Him188 Him188 added this to the 2.8.0-M1 milestone Sep 11, 2021
@Him188
Copy link
Member

Him188 commented Sep 11, 2021

问题1：待review（考虑失败时之前的检测方案？）
问题2：2.8.0-M1 放出测试，测试一个月到 2.8.0 没问题那就是没问题了

Him188
Him188 requested changes Sep 12, 2021
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public inline fun Image(imageId: String)
和
Image.Companion.fromId 也应该添加这些参数的重载

@sandtechnology
Copy link
Collaborator Author

public inline fun Image(imageId: String)
和
Image.Companion.fromId 也应该添加这些参数的重载

对于这些参数的重载应该是无意义的（这根据服务器上存储的文件而定而非由用户指定） 在没有得到实际文件前只提供 imageId 来构造也没有问题？

@sandtechnology
Copy link
Collaborator Author

Ready for reviewing again

@sandtechnology
Copy link
Collaborator Author

Ready for reviewing again

@sandtechnology
Copy link
Collaborator Author

Ready for reviewing again

@sandtechnology
Copy link
Collaborator Author

Ready for reviewing again

Karlatemp
Karlatemp approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码逻辑似乎无问题

@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Sep 15, 2021
@Him188 Him188 merged commit 4ce57f5 into mamoe:dev Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
N 优先级: 一般 t:feature 类型: 新特性 x:protocol 属性: 协议相关 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.8.0-M1
3 participants
@sandtechnology @Him188 @Karlatemp