Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mockHonorMember #2473

Merged
merged 8 commits into from
Mar 29, 2023
Merged

fix mockHonorMember #2473

merged 8 commits into from
Mar 29, 2023

Conversation

Nambers
Copy link
Contributor

@Nambers Nambers commented Feb 4, 2023 •
edited
Loading

CCWP CYIN`)WKLM6UVQEPIN

@Nambers Nambers changed the title fix mocHonorMember fix mockHonorMember Feb 5, 2023
@Karlatemp Karlatemp self-requested a review February 6, 2023 04:25
@Karlatemp Karlatemp added the s:mock 子系统: mirai-core-mock label Feb 6, 2023
Him188
Him188 reviewed Feb 19, 2023
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加点注释? 看了好几分钟没看太懂

@Nambers
Copy link
Contributor Author

Nambers commented Feb 19, 2023

加点注释? 看了好几分钟没看太懂

这个主要是修: 修改 this.group.honorMembers 后不会同步到 queryHonorHistory api 的查询结果

@Nambers Nambers requested review from Him188 and removed request for Karlatemp February 19, 2023 15:51
@Karlatemp Karlatemp self-requested a review February 22, 2023 01:23
@Nambers Nambers requested a review from Karlatemp March 26, 2023 16:02
@Him188 Him188 merged commit 1a8af78 into mamoe:dev Mar 29, 2023
@Him188 Him188 added this to the 2.15.0-RC milestone Mar 29, 2023
StageGuard pushed a commit to StageGuard/mirai that referenced this pull request Apr 14, 2023
@Nambers
[mock] fix mockHonorMember (mamoe#2473)
7dcc87d 
* fix mirai-core-mock honorMember

* add comments

* manually fetch honor data

* update implement

* remove deprecated

* chore: update test cases

* improve style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
s:mock 子系统: mirai-core-mock
Projects
None yet
Milestone
2.15.0-RC
Development

Successfully merging this pull request may close these issues.
3 participants
@Nambers @Him188 @Karlatemp