Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix message source logic #2513

Merged
merged 13 commits into from
Mar 29, 2023
Merged

[core] Fix message source logic #2513

merged 13 commits into from
Mar 29, 2023

Conversation

Karlatemp
Copy link
Member

  • Fix quote replying
  • Fix MessageSource.time

@Karlatemp Karlatemp added x:protocol 属性: 协议相关 M 优先级: 主要 t:problem 类型: 不容易归类为特性或 bug 的综合问题 s:core 子系统: mirai-core labels Feb 17, 2023
This was linked to issues Feb 17, 2023
QuoteReply 处理错误 #2510
Closed
在私聊环境发送的私聊消息引用在 Android 客户端无法定位上下文 #2063
Closed
安卓客户端发送的 Quoto 中 message source id 有误 #2495
Closed
cannot find member for OnlineMessageSourceFromGroupImpl #2277
Closed
@cssxsh
Copy link
Contributor

cssxsh commented Feb 19, 2023

这个 #2122 有可能顺便修了吗

@Him188 Him188 added the x:behavior-change 属性: 行为变更 (API 不变, 行为改变) label Feb 19, 2023
@Him188 Him188 self-requested a review February 19, 2023 11:57
@Him188 Him188 added this to the 2.15.0-RC milestone Feb 19, 2023
@Karlatemp Karlatemp modified the milestones: 2.15.0-RC, 2.15.0-M1 Mar 12, 2023
@Karlatemp Karlatemp force-pushed the core/msg-source branch 2 times, most recently from 44cdf97 to 3c98707 Compare March 18, 2023 15:24
@Him188
Copy link
Member

Him188 commented Mar 18, 2023

为什么 snapshots failed 了呢

@Him188
Copy link
Member

Him188 commented Mar 18, 2023

懂了, branch 名字包含 /

@StageGuard StageGuard mentioned this pull request Mar 20, 2023
Closed
@Him188
Copy link
Member

Him188 commented Mar 21, 2023

dev 修了发 snapshot

@Him188
Copy link
Member

Him188 commented Mar 21, 2023 •
edited by Karlatemp
Loading

这个 #2122 有可能顺便修了吗

@Karlatemp

@Karlatemp
Copy link
Member Author

这个 #2122 有可能顺便修了吗

看这个 issue 的 comments

@Karlatemp Karlatemp linked an issue Mar 23, 2023 that may be closed by this pull request
MessageSyncEvent 的 source 的 target 为机器人，而不是 实际上 的消息发送对象 #2122
Closed
@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Mar 29, 2023
@Him188
Copy link
Member

Him188 commented Mar 29, 2023

你可以合

@Karlatemp Karlatemp merged commit 893fb3e into dev Mar 29, 2023
@Karlatemp Karlatemp deleted the core/msg-source branch March 29, 2023 15:28
@cssxsh cssxsh mentioned this pull request Apr 11, 2023
Open
@Karlatemp Karlatemp mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandtechnology sandtechnology sandtechnology left review comments

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
M 优先级: 主要 s:core 子系统: mirai-core t:problem 类型: 不容易归类为特性或 bug 的综合问题 x:behavior-change 属性: 行为变更 (API 不变, 行为改变) x:protocol 属性: 协议相关 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.15.0-RC
4 participants
@Karlatemp @cssxsh @Him188 @sandtechnology