Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add size into MockImage from uploading #2515

Merged
merged 1 commit into from
Feb 18, 2023
Merged

add size into MockImage from uploading #2515

merged 1 commit into from
Feb 18, 2023

Conversation

Nambers
Copy link
Contributor

@Nambers Nambers commented Feb 18, 2023

理论可以从 upload 拿到 size, width 和 height
后两个我还没什么思路拿到, ImageIO 可能可以

@Him188 Him188 added this to the 2.15.0-RC milestone Feb 18, 2023
@Him188
Copy link
Member

Him188 commented Feb 18, 2023

确实, 但是 mock 有必要解析 width 和 height 吗

@Him188 Him188 merged commit cc22174 into mamoe:dev Feb 18, 2023
@Nambers
Copy link
Contributor Author

Nambers commented Feb 18, 2023 •
edited
Loading

确实, 但是 mock 有必要解析 width 和 height 吗

我觉得至少给个非0值？
不过应该是有方法可以拿到的

确实好像没什么必要, size 是因为调用 isUploaded 需要

@Nambers Nambers deleted the fix-mockImage_size branch February 18, 2023 22:13
@Him188 Him188 modified the milestones: 2.15.0-RC, 2.15.0-M1 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@Nambers @Him188