fix: ProducerReady #2633
Closed
fix: ProducerReady #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Him188
requested changes
Apr 17, 2023
| } catch (e: Exception) { | ||
| finishExceptionally(e) | ||
| } | ||
| val ready = coroutineScope.launch(start = CoroutineStart.LAZY) { |
There was a problem hiding this comment.
Suggested change
| val ready = coroutineScope.launch(start = CoroutineStart.LAZY) { | |
| private val ready = coroutineScope.launch(start = CoroutineStart.LAZY) { |
| @@ -104,6 +95,8 @@ internal class CoroutineOnDemandValueScope<T, V>( | |||
| val deferred = CompletableDeferred<V>(coroutineScope.coroutineContext.job) | |||
| if (!compareAndSetState(state, ProducerState.Producing(state.producer, deferred))) { | |||
| deferred.cancel() // avoid leak | |||
| } else { | |||
| (state.producer as Producer).ready.start() | |||
|
想好没。。。 |
|
最近太忙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
按照状态图的设计，
Producer线程的启动时间点应为 ProducerReady -> Producing故将原本
init的行为改为主动调用close #2623