Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] provide isFirstLogin and getReLoginCause in BotAuthInfo #2664

Merged
merged 8 commits into from
Jun 20, 2023
Merged

[core] provide isFirstLogin and getReLoginCause in BotAuthInfo #2664

merged 8 commits into from
Jun 20, 2023

Conversation

StageGuard
Copy link
Member

@StageGuard StageGuard commented May 10, 2023 •
edited by Him188
Loading

CLOSE #2660

@Him188 Him188 added this to the 2.15.0-RC milestone May 10, 2023
Him188
Him188 requested changes May 10, 2023
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing tests

mirai-core/src/commonMain/kotlin/network/components/SsoProcessor.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/network/components/SsoProcessor.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
Him188
Him188 reviewed May 11, 2023
View reviewed changes
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt Outdated Show resolved Hide resolved
@Him188 Him188 requested a review from Karlatemp May 11, 2023 09:32
@Him188 Him188 added the s:core 子系统: mirai-core label May 11, 2023
@StageGuard @Him188
Update mirai-core-api/src/commonMain/kotlin/auth/BotAuthorization.kt
5d1860e 
我觉得这个描述不太好，因为这里是 `authorize` 过程而不是 `login` 过程

Co-authored-by: Him188 <Him188@mamoe.net>
@StageGuard
Copy link
Member Author

怎么 commit suggestion 会会直接 apply suggestion，我还以为是添加评论

@Him188 Him188 self-requested a review May 20, 2023 23:30
@Him188 Him188 requested a review from Karlatemp May 27, 2023 14:36
@Him188
Copy link
Member

Him188 commented May 27, 2023

@StageGuard 有地方 build fail 了, 修一下?

@StageGuard
Copy link
Member Author

@StageGuard 有地方 build fail 了, 修一下?

我的 IDE 会把 kotlin.jvm.* import 删掉，不知道为什么，大概是因为这个

@Him188 Him188 merged commit 545e5bb into mamoe:dev Jun 20, 2023
@StageGuard StageGuard deleted the authorization_property branch June 22, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
s:core 子系统: mirai-core
Projects
None yet
Milestone
2.15.0-RC
Development

Successfully merging this pull request may close these issues.

QR code 扫码登录重复登录导致账号被彻底冻结
3 participants
@StageGuard @Him188 @Karlatemp