Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: SuperFaceProtocol #2722

Merged
merged 24 commits into from
Sep 3, 2023
Merged

add: SuperFaceProtocol #2722

merged 24 commits into from
Sep 3, 2023

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Jul 3, 2023 •
edited
Loading

close #2621

@cssxsh cssxsh changed the title add: AnimatedStickerProtocol add: SuperFaceProtocol Jul 4, 2023
@Him188 Him188 added this to the 2.16.0-RC milestone Jul 6, 2023
@Karlatemp
Copy link
Member

Karlatemp commented Jul 20, 2023 •
edited
Loading 

Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 348 out of bounds for length 348
	at net.mamoe.mirai.message.data.Face.<clinit>(Face.kt:895)
	... 45 more

@Karlatemp
Copy link
Member 

java.lang.IllegalArgumentException: Polymorphic serializer for class net.mamoe.mirai.message.data.SuperFace has property 'type' that conflicts with JSON class discriminator. You can either change class discriminator in JsonConfiguration, rename property with @SerialName annotation or fall back to array polymorphism

Karlatemp
Karlatemp reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestMiraiCode
MessageVisitorTest

@Karlatemp Karlatemp added t:feature 类型: 新特性 x:protocol 属性: 协议相关 s:core 子系统: mirai-core labels Jul 24, 2023
Him188
Him188 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

标一下 since 就可以了

还有 CI fail 了

@StageGuard StageGuard merged commit 93ccce1 into mamoe:dev Sep 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
s:core 子系统: mirai-core t:feature 类型: 新特性 x:protocol 属性: 协议相关
Projects
None yet
Milestone
2.16.0-RC
Development

Successfully merging this pull request may close these issues.

支持新表情
4 participants
@cssxsh @Karlatemp @Him188 @StageGuard