Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci upload #2725

Merged
merged 1 commit into from
Aug 12, 2023
Merged

fix: ci upload #2725

merged 1 commit into from
Aug 12, 2023

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Jul 10, 2023

现在这个上传有点鸡肋

我改成了上传 MavenLocal 的 cache

@Karlatemp
Copy link
Member

= = 分开的目的就是为了能够只下载需要更新的部分

@Him188
Copy link
Member

Him188 commented Jul 29, 2023

= = 分开的目的就是为了能够只下载需要更新的部分

我觉得没有这个需求

@Him188 Him188 requested a review from Karlatemp July 29, 2023 06:07
@Him188 Him188 added the s:build 子系统:构建相关 label Jul 29, 2023
@Karlatemp
Copy link
Member

= = 分开的目的就是为了能够只下载需要更新的部分

我觉得没有这个需求

一个 pr 可能只有 core 或者 console 有变更,整合到一起的话测试者要下载只能全部一起下载

@Him188
Copy link
Member

Him188 commented Jul 29, 2023

那其实可以都传,反正空间免费

@Karlatemp
Copy link
Member

那其实可以都传,反正空间免费

主要是这一次都传到了一个地方,调试者要下就只能一起全部下

@cssxsh
Copy link
Contributor Author

cssxsh commented Jul 29, 2023

那其实可以都传,反正空间免费

主要是这一次都传到了一个地方,调试者要下就只能一起全部下

可以调整一下,分成三份,core console logging

@cssxsh
Copy link
Contributor Author

cssxsh commented Jul 29, 2023

那其实可以都传,反正空间免费

主要是这一次都传到了一个地方,调试者要下就只能一起全部下

不过说实际的,一般都是直接拿 https://repo.mirai.mamoe.net/snapshots 来做 上游
原本 ci 的下载实属鸡肋,又没有pom信息,莫得依赖

@Him188 Him188 merged commit a7d9039 into mamoe:dev Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:build 子系统:构建相关
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants