Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Manchester City Council #758

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Updated Manchester City Council #758

merged 1 commit into from
Mar 14, 2023

Conversation

dt215git
Copy link
Contributor

Addresses some issues from #756:

  • Uprn pads to 12 digits if leading 0 is missing
  • h3 text used to identify waste collections rather than img alt text
  • DUE TODAY removed from waste type description , prevents icon mapping issue 2023-03-13: Blue Bin DUE TODAY [None]
  • New test case added for additional waste types
  • Icon map updated with additional waste types
Testing source manchester_uk ...
  found 15 entries for domestic
    2023-03-13: Blue Bin [mdi:recycle]
    2023-03-27: Blue Bin [mdi:recycle]
    2023-04-10: Blue Bin [mdi:recycle]
    2023-03-20: Brown Bin [mdi:glass-fragile]
    2023-04-03: Brown Bin [mdi:glass-fragile]
    2023-04-17: Brown Bin [mdi:glass-fragile]
    2023-03-20: Green Bin [mdi:leaf]
    2023-03-20: Green Bin [mdi:leaf]
    2023-04-03: Green Bin [mdi:leaf]
    2023-04-03: Green Bin [mdi:leaf]
    2023-04-17: Green Bin [mdi:leaf]
    2023-04-17: Green Bin [mdi:leaf]
    2023-03-20: Black / Grey Bin [mdi:trash-can]
    2023-04-03: Black / Grey Bin [mdi:trash-can]
    2023-04-17: Black / Grey Bin [mdi:trash-can]
  found 21 entries for large_domestic
    2023-03-17: Green Bin [mdi:leaf]
    2023-03-17: Green Bin [mdi:leaf]
    2023-03-31: Green Bin [mdi:leaf]
    2023-03-31: Green Bin [mdi:leaf]
    2023-04-14: Green Bin [mdi:leaf]
    2023-04-14: Green Bin [mdi:leaf]
    2023-03-17: Large Blue Container [mdi:recycle]
    2023-03-31: Large Blue Container [mdi:recycle]
    2023-04-14: Large Blue Container [mdi:recycle]
    2023-03-24: Large Brown Container [mdi:glass-fragile]
    2023-04-07: Large Brown Container [mdi:glass-fragile]
    2023-03-14: Large Domestic Waste Container [mdi:trash-can]
    2023-03-16: Large Domestic Waste Container [mdi:trash-can]
    2023-03-21: Large Domestic Waste Container [mdi:trash-can]
    2023-03-23: Large Domestic Waste Container [mdi:trash-can]
    2023-03-28: Large Domestic Waste Container [mdi:trash-can]
    2023-03-30: Large Domestic Waste Container [mdi:trash-can]
    2023-04-04: Large Domestic Waste Container [mdi:trash-can]
    2023-04-06: Large Domestic Waste Container [mdi:trash-can]
    2023-04-11: Large Domestic Waste Container [mdi:trash-can]
    2023-04-13: Large Domestic Waste Container [mdi:trash-can]

@mampfes: Haven't changed the name of the source file so legacy configs will still work, but it should probably be manchester_gov_uk.py rather than manchester_uk.py

@mampfes
Copy link
Owner

mampfes commented Mar 14, 2023

Great, thanks!

@dt215git dt215git deleted the manc branch March 14, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants