Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp array #324

Merged
merged 13 commits into from
Jan 28, 2025
Merged

Timestamp array #324

merged 13 commits into from
Jan 28, 2025

Conversation

Alex-PLACET
Copy link
Collaborator

No description provided.

@Alex-PLACET Alex-PLACET self-assigned this Jan 20, 2025
@Alex-PLACET Alex-PLACET marked this pull request as draft January 20, 2025 12:49
@Alex-PLACET Alex-PLACET force-pushed the temporal_layout branch 2 times, most recently from 87b4149 to 1718131 Compare January 21, 2025 13:31
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 85.20710% with 25 lines in your changes missing coverage. Please review.

Project coverage is 92.06%. Comparing base (2b5b248) to head (26e3db1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
include/sparrow/types/data_type.hpp 52.17% 11 Missing ⚠️
...nclude/sparrow/layout/temporal/timestamp_array.hpp 95.68% 5 Missing ⚠️
src/array_factory.cpp 0.00% 4 Missing ⚠️
include/sparrow/layout/dispatch.hpp 25.00% 3 Missing ⚠️
include/sparrow/builder/builder.hpp 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   92.20%   92.06%   -0.14%     
==========================================
  Files          80       82       +2     
  Lines        6000     6174     +174     
==========================================
+ Hits         5532     5684     +152     
- Misses        468      490      +22     
Flag Coverage Δ
unittests 92.06% <85.20%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-PLACET Alex-PLACET requested review from JohanMabille, Klaim and DerThorsten and removed request for Klaim January 23, 2025 13:00
@Alex-PLACET Alex-PLACET marked this pull request as ready for review January 23, 2025 13:00
@Alex-PLACET Alex-PLACET marked this pull request as draft January 23, 2025 13:48
@Alex-PLACET Alex-PLACET changed the title Temporal layout Timestamp array Jan 24, 2025
@Alex-PLACET Alex-PLACET marked this pull request as ready for review January 24, 2025 10:43
Copy link
Collaborator

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need to add friendship in primitive_array and to define arrow_traits for duration types because they are internally hold in a primitive_array while their associated layout will be another type is an argument for captuing out of primitive_array the common implementation. This should be done in a dedicated PR though.

@JohanMabille JohanMabille merged commit 22120e6 into man-group:main Jan 28, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants