-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp array #324
Timestamp array #324
Conversation
87b4149
to
1718131
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 92.20% 92.06% -0.14%
==========================================
Files 80 82 +2
Lines 6000 6174 +174
==========================================
+ Hits 5532 5684 +152
- Misses 468 490 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
120df6f
to
24af55e
Compare
24af55e
to
0753419
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need to add friendship in primitive_array
and to define arrow_traits
for duration types because they are internally hold in a primitive_array
while their associated layout will be another type is an argument for captuing out of primitive_array
the common implementation. This should be done in a dedicated PR though.
No description provided.