Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Other api endpoints #2

Closed
mananchawla2005 opened this issue Oct 17, 2020 · 15 comments
Closed

Check Other api endpoints #2

mananchawla2005 opened this issue Oct 17, 2020 · 15 comments

Comments

@mananchawla2005
Copy link
Owner

Check other api endpoints also for banned repositories and pr's marked as hacktoberfest-accepted

@sadakchap
Copy link
Contributor

Hi @mananchawla2005 , I would like to work on this. May I?

@mananchawla2005
Copy link
Owner Author

Sure @sadakchap

@sadakchap
Copy link
Contributor

Hi @mananchawla2005 , I have some queries -

  • since we are only taking repo url in input, which on submit makes a request to \check endpoint,,, should I only update the octokit query to check for banned repos or you suggest a better way

  • Again, we are taking repo url, for checking pr's as hacktoberfest-accept, do we need to have different form/input field and hit different route.

Please, let me know your views 🙏

@mananchawla2005
Copy link
Owner Author

No it would be better if you combine it all together in one route and after checking all the conditions send the response. @sadakchap

@sadakchap
Copy link
Contributor

No it would be better if you combine it all together in one route and after checking all the conditions send the response. @sadakchap

Ok, I will try implementing that and let you know about it.

@mananchawla2005
Copy link
Owner Author

@sadakchap hey you still working on it?

@sadakchap
Copy link
Contributor

@sadakchap hey you still working on it?

I can't figure out how to check for banned repos 🙁.
Can you give some hints ?

@mananchawla2005
Copy link
Owner Author

mananchawla2005 commented Oct 22, 2020

@sadakchap check for issues like this (OpenSourceTogether/Hacktoberfest-2020#146) opened by @hacktoberfest-team on the repository,
Every banned repo has this issue with the same topic so it will be easy to identify it.

@sadakchap
Copy link
Contributor

Hi @mananchawla2005 , Please check the PR, and let me know if you need any changes

@mananchawla2005
Copy link
Owner Author

Hi @mananchawla2005 , Please check the PR, and let me know if you need any changes

Yeah I mentioned it in the pr itself

@sadakchap
Copy link
Contributor

@mananchawla2005 , for checking close PR, should I do it in same route /check ??

For that, I'll checking for /pulls/ substring, if it exists, then only checking for that specified PR.

@mananchawla2005
Copy link
Owner Author

@sadakchap yeah check in the same route

@mananchawla2005
Copy link
Owner Author

@sadakchap Well nice it works perfectly. Maybe you could open an issue and apply that to the api endpoint also??

@sadakchap
Copy link
Contributor

@sadakchap Well nice it works perfectly. Maybe you could open an issue and apply that to the api endpoint also??

Thanks @mananchawla2005 for helping me 🤗 and for patience.
I will open an issue for API

@mananchawla2005
Copy link
Owner Author

Thanks

mananchawla2005 pushed a commit that referenced this issue Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants