Extracting language specific strings from golang #779

[Arker123]

This pull request (PR) aims to enhance the codebase by implementing a feature to extract language-specific strings from Go (Golang) binaries.

TODO:-

• Extract strings from the .text segment.
• Add comprehensive tests for various versions of Go.

[williballenthin]

also, strongly recommend creating some tests as you're developing this code, to assert that the changes you're making help improve the features declared in the tests.

[mr-tz]

Current results look promising, nice progress!

[Arker123]

By the way, I'd love to hear your thoughts about suggestion Arker123#3 (comment). Let me know what you think.

[Arker123]

quick curiosity: 'I' format works, 'L' doesn't. Why? Thanks!

[williballenthin]

since this is for an array (not struct) the formats are declared here: https://docs.python.org/3/library/array.html

I is for 2 byte words and L is for 4 bytes (and Q for 8 bytes). Lowercase variants are for signed versus uppercase for unsigned. here we want 4 byte unsigned since it doesn't make sense for addresses/sizes to be negative (signed).

[williballenthin]

and it seems like we want "L" but I used "I" which seems like a mistake. i should have tested this.

when you say it doesn't work, what are you observing?

[Arker123]

See: 5260cb6 you did use the "L" format initially. However, during my testing and debugging process, I observed that the "L" format was not working as expected. While making some adjustments to the code, I surprisingly discovered that the "I" format magically worked instead. I apologize for not communicating this clearly earlier.

It's still unclear to me why the "I" format ended up working while the "L" format did not.

[Arker123]

Now handle language specific strings separately:-

[mr-tz]

Doesn't this also print strings twice potentially?

I'd suggest to roll back 722e82a and consider using the proposed changes in Arker123#6.

[mr-tz]

Nice work, @Arker123 and @williballenthin!