Introduce an iter_log method to iterate through logs of a same file #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
ho wow ! it's hell complicated to sign the CLA ! |
mrguiman
force-pushed
the
log_iterator_v1
branch
2 times, most recently
from
67e14da to
deab1a7
Compare
|
@puffyCid you think you can merge this PR ? |
|
hi @jrouaix I tested the changes, all the tests passed. However, there are a few conflicts between this PR/branch and main. Could you update the PR to sync with the latest changes? |
the LogIterator struct iterates through catalog data the build_log method now uses LogIterator to consolidate every log into a vector
jrouaix
force-pushed
the
log_iterator_v1
branch
from
deab1a7 to
62b95af
Compare
|
updated & ready to merge @puffyCid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to the previously created issue #14, here's a first proposition.
We had to test this on our own sysdiags since we do not have yours available, so it'll need more testing on your end, but we noticed an improvement in peak memory usage from ~970mb to ~600mb when parsing the logs.
There's still improvements to be made of course, we introduced an iterator on the surface but it could potentially be iterators all the way down, however the changes required would be substantial.
Here you'll notice that we moved most of the logic from build_log to a new LogIterator structure that itself is used by build_log.
We didn't address the fact that all data is first loaded as a UnifiedLogData, which in our opinion constitutes most of the remainder of the memory usage, since we don't know if that is even possible at that point.
Let me know what you think !