Auto-convert git/ssh-urls to https with GithubPRPlanPlugin

[jleopold28]

When attempting to clone an https repository (https://github.com/blah/foo), the pipeline actually pulls via the git protocol (git://github.com/blah/foo).

This causes a problem when we execute the curl command to post comments.
See:

+ curl -H 'Authorization: token ****' -X POST -d @/home/jenkins/workspace/_terraform-pipeline-example_PR-4@tmp/body.txt -H 'Content-Type: application/json' -D comment.headers git://github.com/api/v3/repos/foo/terraform-pipeline-example/issues/4/comments
curl: (1) Protocol git not supported or disabled in libcurl

[kmanning]

It looks like you're using the GithubOrg jenkins plugin, and you've added behavior to "Checkout over SSH". As a result, the git url that the plugin is finding has the git:// protocol instead of an https:// protocol.

[kmanning]

@bondezbond has also run into this issue, and we talked through it a bit.

I think there are 2 possible options here:

1. We can advertise the withRepoHost() method in the README, and you can override the github URL that is being used to check the project out.
2. We can auto-magically check and replace the git:// protocol with https://. This might be a little awkward. Since the user chose to check the repo out with SSH, we don't know if their github instance is available over http or https. Though, honestly we could just pick https and if we're wrong, it's not the worst situation in the world. If our auto-magic choice doesn't work, they can fall back to option 1 and specify the full url themselves.

[kmanning]

Have we validated that the PR link is constructed correctly for the public github?

[kmanning]

Bumping this to v5.10, so we can cut a v5.9 release

[jleopold28]

Have we validated that the PR link is constructed correctly for the public github?

You mean posting the plan results to public github? I remember testing that when we did the initial release