Export isClusterScoped #95
Conversation
| @@ -99,7 +99,7 @@ func InjectOwner(owner Owner) Transformer { | |||
| } | |||
| } | |||
|
|
|||
| func isClusterScoped(kind string) bool { | |||
| func IsClusterScoped(kind string) bool { | |||
There was a problem hiding this comment.
As you can tell from the TODO, I always considered this function a kind of placeholder, until I (or someone, hint, hint!) could discover The Right Way. I'm happy to export it, but I wish it wasn't so "hard-codey". 😄
There was a problem hiding this comment.
Brought this up to #controller-runtime Slack channel. link
I guess we can simply use the Discovery API (https://pkg.go.dev/k8s.io/client-go/discovery) to query the APIResource by GVK.
However, there's a performance aspect to think about: every call to isClusterScoped shouldn't go and actually hit the API server. I asked in that Slack thread about a cache+informer+watcher mechanism for APIResources.
There was a problem hiding this comment.
@jcrossley3 kubernetes-sigs/controller-runtime#2136
That is a new PR that exposes a functionality IsAPINamespaced. Not sure if that can be used as-is, since it requires a scheme and a restMapper.
There was a problem hiding this comment.
Anyway, I think we can close this PR and leave isClusterScoped internal. I will use the IsApiNamespaced from kubernetes-sigs/controller-runtime#2136 in my usecase.
No description provided.