Skip to content

Commit

Permalink
Merge pull request #179 from manifoldfinance/178-mevethredeemcreamuin…
Browse files Browse the repository at this point in the history
…t256srcmevethsoll723-l744-ignores-return-value

feat: use safeTransferFrom for cream transfer
  • Loading branch information
ControlCplusControlV committed Aug 28, 2023
2 parents 8104a52 + 9c26f0e commit 216fe89
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/MevEth.sol
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import { OFTWithFee } from "./layerZero/oft/OFTWithFee.sol";
/// @dev LSR is represented through an ERC4626 token and interface.
contract MevEth is OFTWithFee, IERC4626, ITinyMevEth {
using SafeTransferLib for WETH;
using SafeTransferLib for ERC20;
using FixedPointMathLib for uint256;

/*//////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -728,7 +729,7 @@ contract MevEth is OFTWithFee, IERC4626, ITinyMevEth {

// Transfer Cream tokens from the sender to the burn address
// safeTransferFrom not needed as we know the exact implementation
creamToken.transferFrom(msg.sender, address(0), creamAmount);
creamToken.safeTransferFrom(msg.sender, address(0), creamAmount);

// Convert the shares to assets and update the fraction elastic and base
uint256 assets = convertToAssets(mevEthAmount);
Expand Down

0 comments on commit 216fe89

Please sign in to comment.